[MUSA][Feat] Upgrade MATE to match CUDA/ROCm behavior on FA#2766
Merged
Conversation
20 tasks
yeahdongcn
changed the title
Collaborator
|
BLOCKER scan:
OVERALL: NO BLOCKERS VERDICT: COMMENT Note: The logic change in is_mate_available() looks correct - checking for either flash_attn_func or flash_attn_varlen_func is appropriate given the new flash_attn_interface import. |
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
yeahdongcn
force-pushed
the
xd/fa_mate_upgrade
branch
from
15c4c69 to
2843edc
Compare
yeahdongcn
added a commit
to yeahdongcn/vllm-omni
that referenced
this pull request
Apr 23, 2026
…ject#2766) Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
lengrongfu
pushed a commit
to lengrongfu/vllm-omni
that referenced
this pull request
May 1, 2026
…ject#2766) Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
…ject#2766) Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
quyifei23
pushed a commit
to quyifei23/vllm-omni
that referenced
this pull request
Jun 6, 2026
…ject#2766) Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Upgrade MATE to match CUDA/ROCm behavior on Flash Attention.
Test Plan
Regression tests.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)